1) It often displays "Mapped charted stations" even if all stations are now known. This is because it checks to see if it can detect objects that are already known, and includes ships, even if they're enemies with no docking ports. Excluding already known objects and objects without docking ports should help, but enemy Molotoks could still mess it up because they have docking ports for some reason.

2) It reveals satellite stations, like turrets and Sung slave quarters even if it fails to reveal the main station. I'm thinking of making it only check stations with a map label, though this would also exclude all but one station in clusters of anarchists, Dwarg, etc., and some friendly stations around places like Starton Eridani and the Arena.

assumedpseudonym 2 Jul 2018:

 One possible workaround to #2 is to give those stations a single space for a map label. It might not be pretty in the coding, but it would work in gameplay.

nms 3 Jul 2018:

I'm not sure what you're suggesting. Currently the main station has a map label and the satellites don't.

assumedpseudonym 3 Jul 2018:

 Disregard the comment, heh. The idea was to give satellite stations that should show up (but wouldn’t under #2) a single space map label to force them to show up. The problem, of course, is that the station’s name is what gets used for the map label. It all made more sense before I had caffeinated. ¬.¬;

nms 3 Jul 2018:

Ah, I was reading "space" as "location". We could use the 'subordinates property to reveal satellites if the main station is revealed, I guess.

assumedpseudonym 3 Jul 2018:

 Wow, we were just crossing wires all over the place, heh. But yeah, 'subordinates might be the best bet to deal with that.

nms 3 Jul 2018:

OK, we can also reveal friendlies with the majorStation attribute unless they're uncharted, even if they have no map label, to deal with big friendly clusters.

https://github.com/kronosaur/Transcendence/commit/025c93f0aae6a987715c78281cd4d2162ec608be

Also makes text translatable and prevents commonwealth ships without docking ports from enabling the military map ROM.

relanat 14 Jul 2018:

Suggestion: The 'unableToConnect' text id could be changed to give some explanation as to why the ROM didn't work.

george moromisato 15 Aug 2018:

Merged PR into 1.8 Beta 3. Thanks!