Juan's introduction works OK but the next two screens say Nil. The second screen lets you undock, you get the data ROM and Sandstorms attack as usual. Docking with Juan after the fight, you get the "The airlock opens" screen fine but the screen after that says "Nil".
https://github.com/NMS127/NMS-Transcendence/commit/3af0945c09dc2fd28cefb4499ba5278c14515ff0
dsRPGDialog didn't know where to find the text because the data passed to it didn't specify the translateType. Possibly someone thought this code would take care of it:
(rpgCharacterSetScreen
&unidJuanCarlos;
{ screen: &dsRPGDialog;
translateType: &msCSCCollectDataROM;
translateID: 'JuanCarlosMeeting
}
)
But that translateType is only used to determine what data to pass to the specified screen. It isn't included in that data (and doing so wouldn't really make sense if the screen isn't dsRPGDialog).
Another issue is that if you dock with Juan's ship when you don't have the mission, you get the meeting intro, followed by the no missions text, which doesn't make sense together:
<Text id="MeetingIntro">
The airlock opens and you see Juan Carlos dressed in a flight
suit.
"Good to see you, %name%!"
</Text>
<Text id="NoMissions">
The airlock refuses to open.
</Text>
Merged PR into 1.8 Beta 3 (https://github.com/kronosaur/Transcendence/pull/93)
Thanks!