Mining colony missions' Borers complement the player on his shooting even if the warlords were killed by passing traffic and the player was half a system away at the time

Might be worth adding a simple 'was I killed by the playerShip' check each time a warlord dies, and ending the mission differently if the answer is no. The player would presumably still receive payment for time and fuel, but the message might be slightly different.

the_shrike 19 Feb 2017:

This is probably the same bug that leads to 'Watch your targets!' warnings coming out of nowhere every now and then.

xephyr 19 Feb 2017:

No, that's irrelevant, Shrike.

The problem is that the mission does not check if the player was the one to destroy the ships. I think this is a good opportunity to move it to a mission type.

george moromisato 23 Feb 2017:

In this particular case, yes, we just need to check if the player is the one who did the deed.

0xabcdef 26 Feb 2017:

Also, the mining colony missions should be defined as <MissionType>s

george moromisato 25 Apr 2017:

Fixed by @giantcabbage's changes in 1.8 Alpha 1.

Resolve